-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable build with statically linked nvimgcodec + hard dependency for dynamic linking #5324
Enable build with statically linked nvimgcodec + hard dependency for dynamic linking #5324
Conversation
9784200
to
17f2a1c
Compare
7b068df
to
1e22517
Compare
…pendency on python package Signed-off-by: Joaquin Anton <janton@nvidia.com>
1e22517
to
0344578
Compare
CI MESSAGE: [12921457]: BUILD STARTED |
CI MESSAGE: [12923923]: BUILD STARTED |
CI MESSAGE: [12923923]: BUILD FAILED |
!build |
CI MESSAGE: [12925672]: BUILD STARTED |
CI MESSAGE: [12925672]: BUILD PASSED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
CI MESSAGE: [12955333]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
CI MESSAGE: [12955481]: BUILD STARTED |
CI MESSAGE: [12955481]: BUILD FAILED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
@@ -144,6 +144,5 @@ def check_nvimgcodec(): | |||
"DALI's experimental image decoder functionality now requires NVIDIA nvImageCodec " | |||
"library to run. You need to install it separately. " | |||
"See https://developer.nvidia.com/nvimgcodec-downloads or simply do " | |||
"`pip install nvidia-nvimgcodec-cu${CUDA_MAJOR_VERSION}` where CUDA_MAJOR_VERSION " | |||
"is your CUDA major version (e.g. 12)." | |||
f"`pip install nvidia-nvimgcodec-cu${__cuda_version__[:2]}`" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -29,12 +29,6 @@ | |||
#include "dali/kernels/common/copy.h" | |||
#include "dali/operators/decoder/image/image_factory.h" | |||
|
|||
#if WITH_DYNAMIC_NVJPEG_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some issues saying that the function was missing during linking. I ended up moving this to a single cc file
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
CI MESSAGE: [12971329]: BUILD STARTED |
CI MESSAGE: [12971329]: BUILD PASSED |
Category:
New feature (non-breaking change which adds functionality)
Description:
Enables WITH_DYNAMIC_NVIMGCODEC=OFF build, which is used in Jetson build
Additional information:
Affected modules and functionalities:
Build system
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A