Enable build with statically linked nvimgcodec + hard dependency for dynamic linking #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
force-pushed
the
dynamic_nvimgcodec_off
branch
5 times, most recently
from
9784200
to
17f2a1c
Compare
jantonguirao
changed the title
jantonguirao
force-pushed
the
dynamic_nvimgcodec_off
branch
2 times, most recently
from
7b068df
to
1e22517
Compare
…pendency on python package Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
dynamic_nvimgcodec_off
branch
from
1e22517
to
0344578
Compare
|
CI MESSAGE: [12921457]: BUILD STARTED |
jantonguirao
changed the title
|
CI MESSAGE: [12923923]: BUILD STARTED |
|
CI MESSAGE: [12923923]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [12925672]: BUILD STARTED |
|
CI MESSAGE: [12925672]: BUILD PASSED |
awolant
approved these changes
Feb 20, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
CI MESSAGE: [12955333]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
CI MESSAGE: [12955481]: BUILD STARTED |
|
CI MESSAGE: [12955481]: BUILD FAILED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
reviewed
Feb 21, 2024
| @@ -144,6 +144,5 @@ def check_nvimgcodec(): | |||
| "DALI's experimental image decoder functionality now requires NVIDIA nvImageCodec " | |||
| "library to run. You need to install it separately. " | |||
| "See https://developer.nvidia.com/nvimgcodec-downloads or simply do " | |||
| "`pip install nvidia-nvimgcodec-cu${CUDA_MAJOR_VERSION}` where CUDA_MAJOR_VERSION " | |||
| "is your CUDA major version (e.g. 12)." | |||
| f"`pip install nvidia-nvimgcodec-cu${__cuda_version__[:2]}`" | |||
JanuszL
reviewed
Feb 21, 2024
| @@ -29,12 +29,6 @@ | |||
| #include "dali/kernels/common/copy.h" | |||
| #include "dali/operators/decoder/image/image_factory.h" | |||
|
|
|||
| #if WITH_DYNAMIC_NVJPEG_ENABLED | |||
There was a problem hiding this comment.
I had some issues saying that the function was missing during linking. I ended up moving this to a single cc file
banasraf
approved these changes
Feb 21, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
CI MESSAGE: [12971329]: BUILD STARTED |
|
CI MESSAGE: [12971329]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
Enables WITH_DYNAMIC_NVIMGCODEC=OFF build, which is used in Jetson build
Additional information:
Affected modules and functionalities:
Build system
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A