Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding git lfs as a compilation prerequisite #5483

Merged

Conversation

mdabek-nvidia
Copy link
Collaborator

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • Documentation update adding git lfs as a compilation prerequisite

Additional information:

Affected modules and functionalities:

  • documentation in docs directory

Key points relevant for the review:

N/A

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Marek Dabek <mdabek@nvidia.com>
@JanuszL JanuszL self-assigned this May 27, 2024
Signed-off-by: Marek Dabek <mdabek@nvidia.com>
Copy link
Contributor

@klecki klecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, they are called submodules, otherwise looks ok.

docs/compilation.rst Outdated Show resolved Hide resolved
Co-authored-by: Krzysztof Lecki <klecki@nvidia.com>
@mdabek-nvidia
Copy link
Collaborator Author

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15372319]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15372319]: BUILD PASSED

@mdabek-nvidia mdabek-nvidia merged commit 78545d4 into NVIDIA:main May 28, 2024
6 of 7 checks passed
mdabek-nvidia added a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants