Extract librosa effects trim to DALI, to avoid breaking changes with newer versions #5568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
reviewed
Jul 18, 2024
| length += frame_length - 1 | ||
| start = start - frame_length // 2 | ||
|
|
||
| return (start, length) |
There was a problem hiding this comment.
Missing new line - won't the linter/black protest?
mzient
approved these changes
Jul 18, 2024
jantonguirao
force-pushed
the
nonsilent_region_reference
branch
2 times, most recently
from
53c7bf2
to
fe2cf6e
Compare
|
CI MESSAGE: [16711102]: BUILD STARTED |
|
CI MESSAGE: [16711287]: BUILD STARTED |
|
CI MESSAGE: [16711287]: BUILD FAILED |
JanuszL
approved these changes
Jul 18, 2024
jantonguirao
force-pushed
the
nonsilent_region_reference
branch
from
222fe1b
to
7c0e73b
Compare
|
CI MESSAGE: [16714202]: BUILD STARTED |
|
CI MESSAGE: [16714202]: BUILD FAILED |
|
CI MESSAGE: [16732963]: BUILD STARTED |
|
CI MESSAGE: [16732963]: BUILD FAILED |
|
CI MESSAGE: [16739311]: BUILD STARTED |
…newer versions Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
nonsilent_region_reference
branch
from
b2066d3
to
383a996
Compare
|
CI MESSAGE: [16739311]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other : Tests
Description:
Additional information:
Affected modules and functionalities:
Tests
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A