-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient Ascent for Caffe and Torch + Layer Viz #1009
Conversation
""" | ||
Get path to file containing model def for deploy/visualization | ||
""" | ||
return os.path.join(self.job_dir,"original.lua") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just call this network.lua
for consistency? Or will there be more/'unoriginal' models?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimZaman This PR is just of my top of branch before finishing my internship. Its the same as those two combines, but rebased with master, and Gradient Ascent for Torch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TimZaman Yeah network.lua would definitely be a better name. Ill try updating this next time I get a chance :)
|
||
fileReader.onreadystatechange = function (){ | ||
if(fileReader.readyState === 4){ | ||
if(fileReader.status === 200 || fileReader.readyState == 4){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 50 you say
if(fileReader.readyState === 4){
and immediatelly after
if(fileReader.status === 200 || fileReader.readyState == 4){
So the latter is always true if the former is true. I bet you meant to say
(fileReader.status === 200 || fileReader.status == 0)
here.
Closing for now (there are merge conflicts anyway). I'd like to revisit this. I've backed up this work at https://github.com/lukeyeager/DIGITS/tree/backup/lucas/gradientAscentWithLayerVis. |
@lukeyeager @TimZaman Sorry school has been super busy. But hopefully soon I'll get some time to revisit this and create some smaller pull requests (such as layer visualizations for Torch models, etc.) once I have a machine up and running. |
Do Not Merge!
Gradient Ascent For Torch and Caffe + Layer Visualizations.
Things left to do: