Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Travis builds for caffe/torch/deb #1143

Merged
merged 2 commits into from
Oct 5, 2016

Conversation

lukeyeager
Copy link
Member

digits-travis-debbuild

  • Updated the test suite to check for the envvar DIGITS_TEST_FRAMEWORK (caffe, torch or none)
    • This could be useful for every-day testing - not just on Eris
    • The hacks I had to add for dealing with inheritance properly are pretty gnarly
  • Test deb package build on Travis (preparing for automatic PPA uploads)

@lukeyeager
Copy link
Member Author

One big positive of this approach is that it's clear when the tests are failing because of Torch (which is usually the case).

[ERROR] torch classify many task failed with error code -11

Looks like Torch is segfaulting!? That's a new one.

@lukeyeager
Copy link
Member Author

Looks like Torch is segfaulting!? That's a new one.

Re-ran the build and it passed.

Copy link
Contributor

@jmancewicz jmancewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit code that looks repeated and could maybe become classes and function that are imported.
Could the mixins be imported?
Could this be a function?
if 'DIGITS_TEST_FRAMEWORK' in os.environ and os.environ['DIGITS_TEST_FRAMEWORK'] != 'none': raise unittest.SkipTest('Non-framework tests skipped')

Also remove coverage/coveralls since we don't do a full test with any
Travis build
@lukeyeager
Copy link
Member Author

Thanks for the feedback Joe. I've refactored some code into a new file: digits/test_utils.py.

@lukeyeager
Copy link
Member Author

When the builds are cached everything finishes in 10 minutes now! 🎉
https://travis-ci.org/NVIDIA/DIGITS/builds/165384804

@lukeyeager lukeyeager merged commit 820c82f into NVIDIA:master Oct 5, 2016
@lukeyeager lukeyeager deleted the separate-tests-by-framework branch October 5, 2016 23:10
SlipknotTN pushed a commit to cynnyx/DIGITS that referenced this pull request Mar 30, 2017
…ework

Separate Travis builds for caffe/torch/deb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants