-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add results browser #195
Add results browser #195
Conversation
I can't see the results yet (see the email I sent you), but from looking at the source this looks promising. 1 quick request: upload only minimized |
Suggestions
Sorry that's a lot! Some should be easy, some may be hard. |
2d260da
to
b343d1b
Compare
Thanks for the fixes! Here are some more suggestions:
And it looks like you haven't addressed these suggestions. Do you have reasons or just haven't gotten around to them yet?
|
f995b41
to
3de17a8
Compare
Point by point:
And as for the other two: I'm not quite finished yet. I'm still undecided on how best to override the default sorting per column. I believe sorting by ID should automatically sort by time started, but again, that's not exactly obvious. Maybe make another column for "start time?" |
Preferred time format Maximum/Minimum/Last value |
Preferred time format--okay. The runtime is a timedelta so I'd probably use the Max/min/last--I can add a tooltip or comment above. All the values presented are from the last run. The assumption I'm making is that the final numbers are from the net that is saved by Caffe (unless it was aborted). I feel like it would be disingenuous to present an "all time minimum" because the current state of the net is not represented by that number. |
I think many people will be interested in knowing which model had the best accuracy. See discussion at #71. |
Interesting. How about both? |
Is there any way to view max/min/last for each output without creating 3x the number of columns? Some sort of radio button / select field for each column? |
I think for a first go, having a form to narrow down results would get us 90% of the way there with much less work. If this is a pain point we can always revisit it later. |
@semisight, you said there's a way to view max/min/last now? I pulled the latest from Also, we should still display something by default when the page loads. Maybe the default columns and "loss" and "accuracy"? |
Yes, there is. It's pretty clunky right now. The multi select presents each column title 3 times: once with a "max" suffix, once with a "min" suffix, and once with no suffix. The max corresponds to the maximum value of that attribute, the min to the minimum value, and the "no suffix" to the latest value (last epoch). I can add a default table in. Are loss and accuracy standard names? Is it okay to "bless" them, considering models aren't required to emit data under those names? |
Since 9ff246e, all the standard networks output |
905de5f
to
3e7c269
Compare
3337660
to
e4cd028
Compare
Can we add a simple page load test in these places: https://github.com/NVIDIA/DIGITS/blob/v2.1.0/digits/test_views.py#L124 This looks pretty cool. Let's squash down to one commit and merge this thing, unless you have any other last-minute features you're trying to get done. |
Show/hide columns: Columns are grouped by 'type'. You can view the metadata like the name, or view numeric values by latest value, min value, or max value. Column filters: * Regex search on non-numeric columns * Range search on numeric columns (use ':' to separate min and max values; omission of min or max substitutes -inf or +inf) Toggle filters: Press 'Show/Hide Filters' to hide filters. Sorting and Multi-sorting: All columns are sortable. Hold shift to sort by multiple columns.
Squashed everything. Here are some release notes, especially for features that aren't documented (yet). Show/hide columns:Columns are grouped by 'type'. You can view the metadata like the name, Column filters:
Toggle filters:Press 'Show/Hide Filters' to hide filters. Sorting and Multi-sorting:All columns are sortable. Hold shift to sort by multiple columns. |
Looks good and thanks for the release notes! Once Travis passes, I'll merge ... |
Cleanup link on homepage Move template location Remove "results browser" language Add some simple tests
Cleanup link on homepage Move template location Remove "results browser" language Add some simple tests
Cleanup link on homepage Move template location Remove "results browser" language Add some simple tests
Cleanup link on homepage Move template location Remove "results browser" language Add some simple tests
Idea
This pull request adds a central page to view results from different ModelJobs. From there, jobs can be compared and filtered in a paginated table. I'm using DataTable, a jquery plugin that seems fairly widely used. The goal is to make finding the best network easier.
Feedback
I'm looking for feedback on how to make this feature more useful. What columns should be added? How do users prefer to compare? Should there be a side-by-side comparison page?
Also, how should this be best integrated into digits? Currently, it is a green button on the front page that links to this. Is this ideal? Where/how should we link to this? Through the navbar?