-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notes functionality added for every Job #283
Conversation
The build has failed because /home/travis/build/NVIDIA/DIGITS/docs/FlaskRoutes.md needs to be regenerated. @lukeyeager , please let me know if I need to change something to make it run successfully or it needs to be configured from the server side. |
@@ -132,6 +133,9 @@ def path_is_local(self, path): | |||
def name(self): | |||
return self._name | |||
|
|||
def notes(self): | |||
return self._notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a check to make sure that _notes
exists and return None
if not. For older jobs I'm getting this error:
AttributeError: 'ImageClassificationModelJob' object has no attribute '_notes'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I have added the condition now. Please check the condition.
@deshraj this is great work, thanks! TravisCI Tests CLA
|
@jmancewicz, how do you feel about the placement for the notes? I don't have a problem with it - it's no worse than the rest of the layout. |
@@ -132,6 +133,12 @@ def path_is_local(self, path): | |||
def name(self): | |||
return self._name | |||
|
|||
def notes(self): | |||
if self._notes: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually doesn't help. You want this:
if hasattr(self, '_notes'):
Ok sure, I will add the test for editing the name also. :) |
@lukeyeager , I have successfully sent the CLA. Also, I have updated the docs. Now, its all working. |
I see that, thanks!
|
@lukeyeager , Is it right to rebase the commits that are already pushed ? Its not recommended to rebase the commits that are pushed. Please let me know if I am wrong. :) |
Squashing Tests |
Yeah, I was thinking about the public branches rule but now it seems fine. Ok I will do this as soon as possible. For the tests part: I think I need some help for that. Can you provide me some link for demo tests and the file where I need to write the tests ? |
You probably want to add a https://github.com/NVIDIA/DIGITS/blob/3791003670/digits/dataset/images/classification/test_views.py#L382 Reference |
notes attribute renamed as _notes Adding and updating notes functionality added in jobs route created for updating the notes of a particular job using PUT request Bug Fix: Check condition added to provide support to previous exisiting jobs Fix: Check conditon updated for previously existing jobs New Docs generated
0e61422
to
4877c36
Compare
Hey @lukeyeager , can you merge the pull request and write the test cases yourself. I am finding it somewhat difficult and time taking. |
Sure, no problem. Thanks for squashing, and for the great work! |
Notes functionality added for every Job
I agree, the location is a bit out of the way, but not worse than what else is going on. It may be moved around in the not too distant future. |
Now, notes can be added for every job. Also, the user can update the notes. Let me know if any changes are required.