Show dataset size #309
Merged
Show dataset size #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool stuff, thanks! Any reason we can't add this for ModelJobs, too? Those snapshots can really rack up in disk space. And it would probably be good to at least write a basic sanity test that checks the size of an empty directory or something. |
|
Sure, I'll do that! |
gheinrich
force-pushed
the
dataset_size
branch
from
2863925
to
a4ba1de
Compare
| else: | ||
| return "%d%s" % (num, suffix) | ||
| num /= 1024.0 | ||
| return "%.1f%s%s" % (num, 'Y', suffix) |
There was a problem hiding this comment.
Is this just a refactoring of digits.utils.sizeof_fmt (here)?
|
Sorry I hadn't noticed there was already a function for this. I'll remove the one I added. |
gheinrich
force-pushed
the
dataset_size
branch
from
a4ba1de
to
1fe2c22
Compare
|
Awesome thanks! Go ahead and merge if this is ready - it looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.