Fix permissions for homepage Abort/Delete buttons #596
Conversation
Makes this test script runnable by itself
lukeyeager
force-pushed
the
fix-home-page-permissions
branch
from
cd40f44
to
5efec65
Compare
|
I had to add a strange fix (suggested in this SO post) for this error: Actually, this is required to run |
| {% endif %} | ||
| {% if job | has_permission('delete') %} | ||
| <a id="delete" class="btn btn-xs btn-danger" {{ ' style=display:none;' if job.status.is_running() }} onClick="return deleteJob('{{job.id()}}');">Delete</a> | ||
| {% endif %} |
There was a problem hiding this comment.
unrelated but why does the job have to not be running to display the delete button? On the job page there is no such limitation.
There was a problem hiding this comment.
Good question. Maybe it fits better? @jmancewicz?
There was a problem hiding this comment.
I think I had it that way, because initially jobs in that list were removed once they completed. I was probably looking to avoid having Abort and Delete visible, and those conditions worked in the initial case.
There was a problem hiding this comment.
Ok, I'll change it in a separate PR.
|
Looks good to me and is working for me. |
Fix permissions for homepage Abort/Delete buttons
No description provided.