Allocate LMDB keys in tcs.Vec object #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luajit heap size must be located in the lower 2GB of addressable memory. There is therefore a limit of 2GB on heap size when using Luajit. This change moves LMDB keys to a tds.Vec object, where memory does not rely on the Lua allocator. close NVIDIA#659
gheinrich
force-pushed
the
dev/torch-lmddb-key-memory
branch
from
106577e
to
bc647b4
Compare
|
Don't pull this in yet, see #687 ; for me luajit gobbles up all the cpu resources it can for no obvious reason. edit: it seems luajit also gobbles up the cpu resources with tds off |
|
From #687 (comment)
|
|
Hmm, this breaks compatibility with the latest packaged version of Torch. Is there any way to fall back to a normal array in case EDIT As I'm reading more about this issue, maybe we should just let it fail? Sounds like not having |
|
On the other hand, it shouldn't be difficult, it's just a one-liner really: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luajit heap size must be located in the lower 2GB of addressable memory.
There is therefore a limit of 2GB on heap size when using Luajit.
This change moves LMDB keys to a tds.Vec object, where memory does not rely on the Lua allocator.
close #659