-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Home page tables #728
Home page tables #728
Conversation
Just added multi-column sorting with shift click. Here I clicked on Status header to see the jobs with Error status, then shift-clicked the Elapsed header to sub-sort by Elapsed time. This would be more useful if something like Loss, Accuracy, or some other metric was listed. However, this is the prerequisite to the addition of grouping the jobs, so I put it out there. |
e6005ad
to
e154b4b
Compare
Lovely! In the current viewer, when i was at 'model page' 2, and clicked on a model, and pressed return, it would return me to the home page (default page 1 i guess). It would be nice to have it return to the same page you were browsing before. Otherwise it's near impossible to have quick looks without opening multiple tabs. |
Oops I made a merge conflict when merging #719. |
@@ -0,0 +1,190 @@ | |||
"use strict"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May need a copyright notice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right.
This looks awesome! I just used it to delete 38 jobs all at once - that used to take forever. |
e154b4b
to
45e3a15
Compare
45e3a15
to
74afccb
Compare
Home page tables
I’ve been experimenting with incorporating the angularjs table (and jQuery/angularjs selection model) that I wrote for an internal app into DIGITS. I know that having a selection model is not popular for web based interfaces and that jQuery actively discourages disabling text selection, but I find the benefits are worth it for the way I like interfaces to feel.
That said, I made a version of the front page with the Datasets and Models columns converted into tables.
Space is tight for the headers and the Datasets starts to wrap. I can probably tweak that.
Moving to the selectable tables, we gain sorting, filtering, and selection.
Row sorting is indicated by the caret in the table header.
Filtering reduces the list to the matching items.
And selection allows the user to delete all the selected jobs at one time.
The Refs column on the Datasets displays the number of Models that reference that Dataset. That allowed me to easily remove unused Datasets.
Aesthetically, I like the the look of the current DIGITS display, and functionally, I like the table view.
So, out of curiosity, I implemented an alternative view which looks somewhat more like the original (check the Toggle View checkbox).
Which still has all the filter, sorting, and selection functionality, but a different view. Without the Delete button on each item, there’s more white space, and perhaps moving Status to the right of Submitted would be better. When the window is smaller, though that will wrap.
The toggle is temporary and intended for anyone who wants to download my home-page-tables branch and see how it feels. I have a very short list of jobs so everything is pretty snappy. I’d be curious to hear how responsive it feels to others.
Also, I’ve removed pagination and just have a long list. I prefer this for data that is bounded and not slow to load. If it is desired to have pagination returned, I can add it back in. I think the angular version is pretty nice.