-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move image gradient extensions to plug-in area #947
Conversation
d7bd01f
to
94ddaee
Compare
64e1cb2
to
08b6630
Compare
08b6630
to
4822b19
Compare
@@ -48,6 +48,10 @@ install: | |||
- pip install -r requirements.txt | |||
- pip install -r requirements_test.txt | |||
|
|||
# image gradients plug-ins | |||
- pip install plugins/data/imageGradients | |||
- pip install plugins/view/imageGradients |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So... you don't actually have to pip install
DIGITS? You only have to install the plugins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No wait, yes you do.
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/pip-59l1vv-build/setup.py", line 5, in <module>
from digits.extensions.data import GROUP as DIGITS_PLUGIN_GROUP
ImportError: No module named digits.extensions.data
I think this Travis build is about to fail, let's see ...
https://travis-ci.org/NVIDIA/DIGITS/builds/162241842
This was the only extension that was hidden by default, right? Can we just get rid of the It seems to me that we can entirely replace the show/hide+envvar system with the uninstalled/installed system. |
a8f6b1f
to
a297ca1
Compare
Sure, this was my original intention but the change disappeared during the rebase. I have re-instated that change.
You're right - I have updated the change, thanks. |
(N) [none] <NONE> | ||
>> A | ||
Using "image-bounding-boxes,image-gradients,all-raw-data" | ||
$ pip install -e $DIGITS_HOME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind if we use _ROOT
instead of _HOME
here? See 800e352.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at all, updated in latest commit
import os | ||
from setuptools import setup, find_packages | ||
|
||
# Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why the copyright isn't at the top of this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in latest commit
Conflicts: digits/extensions/data/__init__.py Conflicts: plugins/data/imageGradients/digitsDataPluginImageGradients/data.py
a297ca1
to
aab35bd
Compare
Move image gradient extensions to plug-in area
This includes several changes:
This depends on PR #927