-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ubuntu 16.04 #965
Conversation
Can cause misleading errors with defunct processes
Rebased after conflict with #800. |
I tried this PR on Ubuntu 14.04. I did a |
Just to try to head off any complaints, if you see this error:
Then you need to run this command to get the new requirements:
In general, you need to run that command anytime there is a change made to |
Add support for Ubuntu 16.04
Several key packages have been upgraded from 14.04 to 16.04.
The gevent upgrade is particularly troublesome because it requires upgrading Flask-Socketio. Which isn't so bad in and of itself, but causes problems for packaging because of a naming conflict (see #476 (comment), miguelgrinberg/python-socketio#23). I can get around the packaging issue, but it's not pretty.
Another issue is that some versions of gunicorn and gevent conflict. So while requirements says that you can use
gevent>=1.0,<=1.1.0
and/orgunicorn>=17.5,<=19.4.5
, it should really read(gevent==1.0 AND gunicorn==17.5) OR (gevent==1.1.0 AND gunicorn==19.4.5)
. Otherwise you get this weird behavior where the Caffe subprocess goes defunct.I also found a funny pydot packaging bug along the way (see commit msg).