Simplify handling of "define box by compositing" #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
Stacked on #2416, marked as draft to avoid accidental merge. |
zasdfgbnm
commented
Jun 14, 2024
|
!build |
naoyam
reviewed
Jun 25, 2024
naoyam
reviewed
Jun 25, 2024
|
!build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is a "define box by compositing", in principle, we should be indexing into the imagined partitioned IterDomain, as shown below"
However, we were not able to do that in the past because indexing only supports backward propagation. With
TensorIndexerandAbstractTensor, we can easily create the imagined partitioned ValGroup and index into it.So there is no need to use the state machine approach to manually combine indices, instead, the index of the imagined partitioned ValGroup can be directly used as the index for the TMA PTX instructions.