Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Promote hoisting of vectorize predicates" #2742

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

liqiangxl
Copy link
Collaborator

@liqiangxl liqiangxl commented Aug 1, 2024

check issue #2741

Regression is recovered after revert, see dashboard.

@liqiangxl liqiangxl requested a review from naoyam August 1, 2024 19:55
@naoyam
Copy link
Collaborator

naoyam commented Aug 1, 2024

I thank both you and Xiao for finding the issue, but I don't think just reverting the PR is the right fix. Let's first create an issue.

@naoyam
Copy link
Collaborator

naoyam commented Aug 1, 2024

Sorry I missed there's already an issue.

@liqiangxl liqiangxl marked this pull request as ready for review August 22, 2024 19:02
@naoyam
Copy link
Collaborator

naoyam commented Aug 22, 2024

!build

@naoyam naoyam merged commit 2af87e1 into main Aug 22, 2024
35 of 36 checks passed
@naoyam naoyam deleted the revert-2628-vec_pred branch August 22, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants