Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Support custom “Delta Degrees of Freedom” for matx::var #420

Closed
AtomicVar opened this issue May 25, 2023 · 1 comment · Fixed by #421
Closed

[FEA] Support custom “Delta Degrees of Freedom” for matx::var #420

AtomicVar opened this issue May 25, 2023 · 1 comment · Fixed by #421

Comments

@AtomicVar
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I found that matx::var do not support the ddof argument like NumPy var. This parameter determines how to do the final division step.

ddof is 0 by default in NumPy, whereas in MatX it is currently fixed at ddof=1. Is it possible to support having the user pass in a custom ddof parameter? A similar feature is implemented by PyTorch, in their var function, where the equivalent argument is correction.

Describe the solution you'd like
I want a var function which looks like

void var(OutType dest, const InType &in, const int ddof = 1, int stream = 0)
@cliffburdick
Copy link
Collaborator

Thanks for the request. That seems easy enough and we will add this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants