Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the use of tmp folders for the server and client. #133

Merged
merged 5 commits into from
Jan 21, 2022

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jan 21, 2022

To remove the "/tmp/fl_server" and "/tmp/fl/uid" workspace dependency for FL server and client.

@yhwen yhwen linked an issue Jan 21, 2022 that may be closed by this pull request
@yhwen yhwen self-assigned this Jan 21, 2022
@yhwen yhwen linked an issue Jan 21, 2022 that may be closed by this pull request
IsaacYangSLA
IsaacYangSLA previously approved these changes Jan 21, 2022
Copy link
Collaborator

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@IsaacYangSLA
Copy link
Collaborator

@SYangster could duplicate the issue on 2.0.5 and didn't see it on this PR.

Copy link
Collaborator

@yanchengnv yanchengnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Yuhong won't be available to address my questions. Let's approve this and get it tested thoroughly.

Copy link
Collaborator

@IsaacYangSLA IsaacYangSLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to be ready for QA.

@IsaacYangSLA IsaacYangSLA merged commit 57152d3 into NVIDIA:main Jan 21, 2022
@yhwen yhwen deleted the remove_tmp_workspace branch April 28, 2022 14:16
holgerroth pushed a commit to holgerroth/NVFlare that referenced this pull request Dec 4, 2023
* Removed the use of tmp folders for the server and client.

* renamed back one of the variable name.

* Removed no used import.

* Removed the no longer needed sleep().

* Removed the no used import.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple FL servers on the same machine
3 participants