-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the use of tmp folders for the server and client. #133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@SYangster could duplicate the issue on 2.0.5 and didn't see it on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Yuhong won't be available to address my questions. Let's approve this and get it tested thoroughly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved to be ready for QA.
* Removed the use of tmp folders for the server and client. * renamed back one of the variable name. * Removed no used import. * Removed the no longer needed sleep(). * Removed the no used import.
To remove the "/tmp/fl_server" and "/tmp/fl/uid" workspace dependency for FL server and client.