Add missing docs and pieces for experiment tracking [skip ci] #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
integration/monai/examples/spleen_ct_segmentation_local/README.md
Outdated
Show resolved
Hide resolved
integration/monai/examples/spleen_ct_segmentation_local/README.md
Outdated
Show resolved
Hide resolved
...en_ct_segmentation_local/jobs/spleen_ct_segmentation_local/app/config/config_fed_server.json
Show resolved
Hide resolved
integration/monai/examples/spleen_ct_segmentation_local/README.md
Outdated
Show resolved
Hide resolved
|
/build |
|
/build |
There was a problem hiding this comment.
Overall looks good.
The only comment is related to the MericsExchanger/MetricsReciever. These are internal implementation details. They shouldn't need to expose to the user. The implementation could be changed later.
User just want to log metrics to stream to MLflow/WandB etc. their experience should be the same regardless they in learner class or train.py class. The only difference should be import package
For Monai, the important point, is that, if user uses FLARE + MONAI + MLFLow, the metrics defined in Monai bundle will be automatically sent over to MLFLOW via FLARE Server.
integration/monai/examples/spleen_ct_segmentation_local/README.md
Outdated
Show resolved
Hide resolved
|
/build |
integration/monai/examples/spleen_ct_segmentation_local/README.md
Outdated
Show resolved
Hide resolved
integration/monai/examples/spleen_ct_segmentation_local/README.md
Outdated
Show resolved
Hide resolved
|
/build |
nvkevlu
changed the title
|
/build |
|
/build |
holgerroth
pushed a commit
to holgerroth/NVFlare
that referenced
this pull request
Dec 4, 2023
…#1981) * add missing docs and pieces for experiment tracking * fix ci and update monai readme * fix configs * rename log to write_log to avoid conflict with wandb log * update mlflow config * make changes for comments, add missing changes * fix ci * remove submit_job scripts to use the cli command instead * address more PR comments * revise wording based on PR comment * revise wording based on PR comment * remove metrics-exchanger from example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing docs and pieces for experiment tracking. Adds examples using MetricsExchanger.
Types of changes
./runtest.sh.