Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update client_api executor docs #2661

Merged
merged 1 commit into from
Jun 25, 2024
Merged

update client_api executor docs #2661

merged 1 commit into from
Jun 25, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jun 24, 2024

Fixes # .

Description

Updated the client_api executor docs to explain the "launch_once" option for in-process and sub-process executors.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

YuanTingHsieh
YuanTingHsieh approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes things clearer

@yhwen yhwen merged commit a133f9f into NVIDIA:main Jun 25, 2024
15 checks passed
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@yhwen @nvidianz
update client_api docs. (NVIDIA#2661)
94f6986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen chesterxgchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhwen @chesterxgchen @YuanTingHsieh