Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the numpy release version #2670

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Fixed the numpy release version #2670

merged 2 commits into from
Jun 26, 2024

Conversation

yhwen
Copy link
Collaborator

@yhwen yhwen commented Jun 26, 2024

Fixes # .

Description

Fixed the wrong numpy version for release.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

YuanTingHsieh
YuanTingHsieh reviewed Jun 26, 2024
View reviewed changes
setup.cfg Outdated Show resolved Hide resolved
@yhwen yhwen merged commit 35cfd33 into NVIDIA:main Jun 26, 2024
15 checks passed
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
@yhwen @nvidianz
Fixed the numpy release version (NVIDIA#2670)
6924bd9 
* Fixed the wrong numpy release version.

* Update the numpy version to 1.26.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhwen @YuanTingHsieh