Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ModelController arguments #2683

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

SYangster
Copy link
Collaborator

ModelController enhancements #2049

  1. BaseFedAvg: change min_clients -> num_clients for clarity now that we hid wait_time_after_min_received and we are sending to num_clients targets rather than all clients.
  2. Improve docstring of sample_clients()
  3. Clarify meaning of timeout in send_model_and_wait() and send_model()
  4. Add min_responses and hide wait_time_after_min_received (Add min_responses to send_model_and_wait() #2675)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SYangster
Copy link
Collaborator Author

/build

@SYangster SYangster merged commit f356e20 into NVIDIA:main Jul 3, 2024
16 checks passed
nvidianz pushed a commit to nvidianz/NVFlare that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants