fix(logging): add "Tool" type to message sender labeling #1412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a logging issue where tool messages were incorrectly labeled as "System" messages in the LoggingCallbackHandler output. The change adds explicit handling for "tool" type messages to improve debugging clarity.
- Adds "Tool" label for messages with type "tool" in the logging callback handler
- Includes comprehensive test coverage to verify the new tool message labeling functionality
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nemoguardrails/logging/callbacks.py | Adds conditional logic to label tool messages as "Tool" instead of defaulting to "System" |
| tests/test_callbacks.py | Adds test case with mock verification to ensure tool messages are properly labeled in logging output |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
tgasser-nv
approved these changes
Sep 24, 2025
Previously, messages of type "tool" were not distinctly labeled in the LoggingCallbackHandler output, causing them to be grouped under "System". This change adds explicit handling for "tool" messages, labeling them as "Tool" in the logs for improved clarity and debugging.
Pouyanpi
force-pushed
the
fix/logging-tool-type
branch
from
27318b6 to
08629b5
Compare
Pouyanpi
added a commit
that referenced
this pull request
Sep 26, 2025
Previously, messages of type "tool" were not distinctly labeled in the LoggingCallbackHandler output, causing them to be grouped under "System". This change adds explicit handling for "tool" messages, labeling them as "Tool" in the logs for improved clarity and debugging.
Pouyanpi
added a commit
that referenced
this pull request
Oct 1, 2025
Previously, messages of type "tool" were not distinctly labeled in the LoggingCallbackHandler output, causing them to be grouped under "System". This change adds explicit handling for "tool" messages, labeling them as "Tool" in the logs for improved clarity and debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, messages of type "tool" were not distinctly labeled in the LoggingCallbackHandler output, causing them to be grouped under "System".
This change adds explicit handling for "tool" messages, labeling them as "Tool" in the logs for improved clarity and debugging.