-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx Bibtext Fix #1559
Sphinx Bibtext Fix #1559
Conversation
Signed-off-by: Jason <jasoli@nvidia.com>
make html | ||
make html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda of a "dumb" fix. Version 2.0.0 of sphinxcontrib-bibtex requires users to either build sphinx twice or add "bibtext.json" to the version control.
Note that this fix will not fix the RTD build, which is equally as problematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, we can just pin sphinxcontrib-bibtex==1.0.0. @tkornuta-nvidia thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blisc those changes are good for local build, but as you pointed out won't solve RTD build - so be effectively loose access to the latest documentation. So how about pinning to sphinxcontrib-bibtex<2.0.0
as suggested:
mcmtroffaes/sphinxcontrib-bibtex#214 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with either solution:
- Pin
sphinxcontrib-bibtex<2.0.0
- Add
bibtext.json
to github
@okuchaiev, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blisc up to you
No description provided.