Fix and improvement for SD #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fayejf
commented
Mar 10, 2021
fayejf
commented
- handle if dot in the filename
- Add flexible input format for VAD tune threshold
Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: fayejf <fayejf07@gmail.com>
nithinraok
approved these changes
Mar 10, 2021
Oktai15
pushed a commit
that referenced
this pull request
Mar 30, 2021
* fix dot in filename issue Signed-off-by: fayejf <fayejf07@gmail.com> * support flexible input format for vad threhold tuning Signed-off-by: fayejf <fayejf07@gmail.com>
michalivne
pushed a commit
to michalivne/NeMo
that referenced
this pull request
Jun 23, 2021
* fix dot in filename issue Signed-off-by: fayejf <fayejf07@gmail.com> * support flexible input format for vad threhold tuning Signed-off-by: fayejf <fayejf07@gmail.com> Signed-off-by: Micha Livne <mlivne@nvidia.com>
mousebaiker
pushed a commit
to mousebaiker/NeMo
that referenced
this pull request
Jul 8, 2021
* fix dot in filename issue Signed-off-by: fayejf <fayejf07@gmail.com> * support flexible input format for vad threhold tuning Signed-off-by: fayejf <fayejf07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.