-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
self.log and fix top-k acc metrics #1878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: fayejf <fayejf07@gmail.com>
titu1994
requested changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. The multi methods should not use self.log, it is called internally.
Signed-off-by: fayejf <fayejf07@gmail.com>
titu1994
approved these changes
Mar 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: fayejf <fayejf07@gmail.com>
Oktai15
pushed a commit
that referenced
this pull request
Mar 30, 2021
* self.log and fix top-k acc metrics Signed-off-by: fayejf <fayejf07@gmail.com> * revert multi Signed-off-by: fayejf <fayejf07@gmail.com> * revert makeup Signed-off-by: fayejf <fayejf07@gmail.com>
michalivne
pushed a commit
to michalivne/NeMo
that referenced
this pull request
Jun 23, 2021
* self.log and fix top-k acc metrics Signed-off-by: fayejf <fayejf07@gmail.com> * revert multi Signed-off-by: fayejf <fayejf07@gmail.com> * revert makeup Signed-off-by: fayejf <fayejf07@gmail.com> Signed-off-by: Micha Livne <mlivne@nvidia.com>
mousebaiker
pushed a commit
to mousebaiker/NeMo
that referenced
this pull request
Jul 8, 2021
* self.log and fix top-k acc metrics Signed-off-by: fayejf <fayejf07@gmail.com> * revert multi Signed-off-by: fayejf <fayejf07@gmail.com> * revert makeup Signed-off-by: fayejf <fayejf07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of PR#1777 that should go to 1.0.0RC
Signed-off-by: fayejf fayejf07@gmail.com