Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self.log and fix top-k acc metrics #1878

Merged
merged 4 commits into from Mar 10, 2021
Merged

self.log and fix top-k acc metrics #1878

merged 4 commits into from Mar 10, 2021

Conversation

fayejf
Copy link
Collaborator

@fayejf fayejf commented Mar 10, 2021

Part of PR#1777 that should go to 1.0.0RC

Signed-off-by: fayejf fayejf07@gmail.com

Signed-off-by: fayejf <fayejf07@gmail.com>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. The multi methods should not use self.log, it is called internally.

nemo/collections/asr/models/classification_models.py Outdated Show resolved Hide resolved
nemo/collections/asr/models/classification_models.py Outdated Show resolved Hide resolved
Signed-off-by: fayejf <fayejf07@gmail.com>
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fayejf and others added 2 commits March 9, 2021 23:50
@fayejf fayejf merged commit 75e7ca8 into r1.0.0rc1 Mar 10, 2021
@fayejf fayejf deleted the fix_log_classification branch March 10, 2021 19:09
Oktai15 pushed a commit that referenced this pull request Mar 30, 2021
* self.log and fix top-k acc metrics

Signed-off-by: fayejf <fayejf07@gmail.com>

* revert multi

Signed-off-by: fayejf <fayejf07@gmail.com>

* revert makeup

Signed-off-by: fayejf <fayejf07@gmail.com>
michalivne pushed a commit to michalivne/NeMo that referenced this pull request Jun 23, 2021
* self.log and fix top-k acc metrics

Signed-off-by: fayejf <fayejf07@gmail.com>

* revert multi

Signed-off-by: fayejf <fayejf07@gmail.com>

* revert makeup

Signed-off-by: fayejf <fayejf07@gmail.com>
Signed-off-by: Micha Livne <mlivne@nvidia.com>
mousebaiker pushed a commit to mousebaiker/NeMo that referenced this pull request Jul 8, 2021
* self.log and fix top-k acc metrics

Signed-off-by: fayejf <fayejf07@gmail.com>

* revert multi

Signed-off-by: fayejf <fayejf07@gmail.com>

* revert makeup

Signed-off-by: fayejf <fayejf07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants