[TTS] Fix incorrect usage of TTSDataset in some files and fix one-line bug in NVIDIA's CMUDict #3594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
blisc
reviewed
Feb 3, 2022
| D�J� D EY2 JH AA1 | ||
| D�J� D EY2 JH AA1 |
There was a problem hiding this comment.
@redoctopus can you take a look and fix this line. Those ? question mark characters aren't even valid unicode characters
There was a problem hiding this comment.
Good catch! I poked around, looks like they're in UTF-16 instead of UTF-8. I've submitted #3597 to fix this.
blisc
approved these changes
Feb 3, 2022
3 tasks
fayejf
pushed a commit
that referenced
this pull request
Mar 2, 2022
Signed-off-by: Oktai Tatanov <oktai.tatanov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oktai Tatanov oktai.tatanov@gmail.com
What does this PR do ?
Collection: [tts]
Changelog
INTERNATIONALused non-existent phonemePR Type: