[TTS] Add speakerID to libritts/get_data.py #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oktai15
previously approved these changes
Feb 15, 2022
subhankar-ghosh
force-pushed
the
update_libritts_getdata
branch
from
e77cf64
to
4576055
Compare
subhankar-ghosh
force-pushed
the
update_libritts_getdata
branch
2 times, most recently
from
60abeee
to
92b7bbf
Compare
Oktai15
approved these changes
Feb 16, 2022
Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>
Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>
Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>
subhankar-ghosh
force-pushed
the
update_libritts_getdata
branch
from
92b7bbf
to
fdb0bb4
Compare
fayejf
pushed a commit
that referenced
this pull request
Mar 2, 2022
* Add speakerid to libritts/get_data.py Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * reformatting change Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com> * removing trailing spaces Signed-off-by: Subhankar Ghosh <subhankar2321@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Subhankar Ghosh subhankar2321@gmail.com
What does this PR do ?
Adds SpeakerID to
process_transcriptmethod of libritts/get_data.pyChangelog
Gets speakerID from the path because the path to every manifest has the speakerID.
Adds the speakerID to the entry as another (key,value) pair.
Usage
Doesn't change how libritts/get_data.py will be called. The manifests will contain speaker field.
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information