fix save_best missing chpt bug, update for setup_tokenizer() changes #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ekmb <ebakhturina@nvidia.com>
ericharper
pushed a commit
that referenced
this pull request
Apr 8, 2022
…3932) * fix save_best missing chpt bug, update for setup_tokenizer() changes Signed-off-by: ekmb <ebakhturina@nvidia.com> * style fix Signed-off-by: ekmb <ebakhturina@nvidia.com>
titu1994
added a commit
that referenced
this pull request
Apr 9, 2022
* update version Signed-off-by: ericharper <complex451@gmail.com> * Stateless timer fix for PTL 1.6 (#3925) * Stateless timer fix for PTL 1.6 Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Stateless timer PTL test Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Fix year Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Style Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Remove unused imports Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Style Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * GPU test Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Style Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * clean import Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: ericharper <complex451@gmail.com> * fix save_best missing chpt bug, update for setup_tokenizer() changes (#3932) * fix save_best missing chpt bug, update for setup_tokenizer() changes Signed-off-by: ekmb <ebakhturina@nvidia.com> * style fix Signed-off-by: ekmb <ebakhturina@nvidia.com> * Fix divide by world size (#3941) Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * remove old doc (#3946) Signed-off-by: ekmb <ebakhturina@nvidia.com> * Fix issues with librosa deprecations (#3950) Signed-off-by: smajumdar <titu1994@gmail.com> * Fix issue with Segfault in ASR models (#3956) * Fix issue with Segfault in ASR models Signed-off-by: smajumdar <titu1994@gmail.com> * Add docstring Signed-off-by: smajumdar <titu1994@gmail.com> * Fix notebook bugs for branch r1.8.0 (#3948) * load the model from ngc Signed-off-by: Yi Dong <doyend@gmail.com> * fix all biomegatron notebook Signed-off-by: Yi Dong <doyend@gmail.com> * fix the typos Signed-off-by: Yi Dong <doyend@gmail.com> * remove output Signed-off-by: Yi Dong <doyend@gmail.com> * fix isort Signed-off-by: Yi Dong <doyend@gmail.com> * fix merge error Signed-off-by: Yi Dong <doyend@gmail.com> * change ntpath for isort workaround Signed-off-by: Yi Dong <doyend@gmail.com> * fix unit test Signed-off-by: Yi Dong <doyend@gmail.com> * fix ci Signed-off-by: Yi Dong <doyend@gmail.com> * fix ci bert pretraining Signed-off-by: Yi Dong <doyend@gmail.com> * make it compatible with main Signed-off-by: Yi Dong <doyend@gmail.com> * add the teste for biomegatron ner Signed-off-by: Yi Dong <doyend@gmail.com> * fix argument Signed-off-by: Yi Dong <doyend@gmail.com> * fix usablity issue Signed-off-by: Yi Dong <doyend@gmail.com> * work around Signed-off-by: Yi Dong <doyend@gmail.com> Co-authored-by: Yi Dong <doyend@gmail.com> Co-authored-by: Eric Harper <complex451@gmail.com> * Fix global batch fit loop (#3936) * add lightning module hooks for global batch Signed-off-by: ericharper <complex451@gmail.com> * clean scripts Signed-off-by: ericharper <complex451@gmail.com> * style Signed-off-by: ericharper <complex451@gmail.com> * remove unused import Signed-off-by: ericharper <complex451@gmail.com> * DP=1 fix Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * set num dataset workers to 2 Signed-off-by: ericharper <complex451@gmail.com> * update validation_loop with GlobalDataFetcher Signed-off-by: ericharper <complex451@gmail.com> * add test global data fetcher Signed-off-by: ericharper <complex451@gmail.com> * Drop last for test ds Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Fix test epoch end Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Style Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Fix eval Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Fix reconfigure microbatch in the complete method Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * add comments Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Set init consumed samples Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * fix shuffle Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * add save_restore_connector arg Signed-off-by: ericharper <complex451@gmail.com> * Fix padding for labels and loss mask Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * GLUE/XNLI CI tests Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * limit val batches in hydra fix Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Restart CI Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Fix unittest Signed-off-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> Co-authored-by: MaximumEntropy <sandeep.subramanian.1@umontreal.ca> * Update max_epochs on megatron configs (#3958) * update config Signed-off-by: ericharper <complex451@gmail.com> * update config Signed-off-by: ericharper <complex451@gmail.com> * update branch Signed-off-by: ericharper <complex451@gmail.com> * update version Signed-off-by: ericharper <complex451@gmail.com> Co-authored-by: Sandeep Subramanian <sandeep.subramanian.1@umontreal.ca> Co-authored-by: Evelina <10428420+ekmb@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com> Co-authored-by: Yi Dong <doyend@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
[NLP] bug fixes for duplex model
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information