ssl fixes #4268
Merged
ssl fixes #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titu1994
requested changes
May 26, 2022
| return self.decoder_layers(encoder_output).transpose(-2, -1) | ||
| out = self.decoder_layers(encoder_output).transpose(-2, -1) | ||
| if self.apply_softmax: | ||
| out = torch.nn.functional.log_softmax(out, dim=-1) |
There was a problem hiding this comment.
You need to update the output_types neural type of this module - when the flag is set to false, it returns logits, when true, log probs. It is important to update the semantics of this module and any downstream modules that accept the output of this class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sam1373 samuelkriman@gmail.com
What does this PR do ?
Collection: ASR
PR Type: