Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to AMI script #4974

Merged
merged 9 commits into from
Sep 25, 2022
Merged

Improvements to AMI script #4974

merged 9 commits into from
Sep 25, 2022

Conversation

SeanNaren
Copy link
Collaborator

@SeanNaren SeanNaren commented Sep 21, 2022 •
edited
Loading

What does this PR do ?

Collection:

  • ASR

Changelog

  • AMI download script improvements

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@SeanNaren
AMI script improvements
df3d992 
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
@SeanNaren
Fix uem
cc84a6b 
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
@SeanNaren
Merge branch 'main' into feat/ami_script
9fca6f8
@SeanNaren SeanNaren self-assigned this Sep 21, 2022
@SeanNaren
style fixes
4ef1e49 
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
nithinraok
nithinraok reviewed Sep 21, 2022
View reviewed changes
scripts/dataset_processing/get_ami_data.py Show resolved Hide resolved
scripts/dataset_processing/get_ami_data.py Show resolved Hide resolved
scripts/dataset_processing/get_ami_data.py Outdated Show resolved Hide resolved
scripts/dataset_processing/get_ami_data.py Outdated Show resolved Hide resolved
scripts/dataset_processing/get_ami_data.py Outdated Show resolved Hide resolved
@SeanNaren
Address review
f18bbe3 
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
nithinraok
nithinraok previously approved these changes Sep 22, 2022
View reviewed changes
@SeanNaren
Style fixes
232bc77 
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
@SeanNaren SeanNaren merged commit bd3b647 into NVIDIA:main Sep 25, 2022
@SeanNaren SeanNaren deleted the feat/ami_script branch September 25, 2022 12:05
SeanNaren added a commit that referenced this pull request Sep 26, 2022
@SeanNaren
Improvements to AMI script (#4974)
2e21ca8
SeanNaren added a commit that referenced this pull request Sep 26, 2022
@SeanNaren
Improvements to AMI script (#4974)
3ab8edf 
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
Jorjeous pushed a commit that referenced this pull request Sep 27, 2022
@SeanNaren @Jorjeous
Improvements to AMI script (#4974)
6c1a136 
Signed-off-by: George Zelenfroynd <zelenfr@ya.ru>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Sep 28, 2022
@SeanNaren @jubick1337
Improvements to AMI script (NVIDIA#4974)
0c113d7 
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 3, 2022
@SeanNaren @jubick1337
Improvements to AMI script (NVIDIA#4974)
0d43b4e 
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
XuesongYang pushed a commit to XuesongYang/NeMo that referenced this pull request Oct 3, 2022
@SeanNaren @XuesongYang
Improvements to AMI script (NVIDIA#4974)
95eda06
XuesongYang pushed a commit to XuesongYang/NeMo that referenced this pull request Oct 4, 2022
@SeanNaren @XuesongYang
Improvements to AMI script (NVIDIA#4974)
5141d12
jubick1337 pushed a commit to jubick1337/NeMo that referenced this pull request Oct 4, 2022
@SeanNaren @jubick1337
Improvements to AMI script (NVIDIA#4974)
aa69500 
Signed-off-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994 pushed a commit to titu1994/NeMo that referenced this pull request Oct 6, 2022
@SeanNaren @titu1994
Improvements to AMI script (NVIDIA#4974)
16b3c3d
XuesongYang pushed a commit to XuesongYang/NeMo that referenced this pull request Oct 10, 2022
@SeanNaren @XuesongYang
Improvements to AMI script (NVIDIA#4974)
988bfca
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@SeanNaren
Improvements to AMI script (NVIDIA#4974)
e18ee3e 
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
@SeanNaren
Improvements to AMI script (NVIDIA#4974)
3413fe3 
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithinraok nithinraok nithinraok approved these changes

@tango4j tango4j Awaiting requested review from tango4j

Assignees

@SeanNaren SeanNaren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanNaren @nithinraok