-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NGC links for Aligner and FastPitch #5235
Conversation
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you also add this IPA aligner into NeMo doc and distinguish wit Arpabet? https://github.com/NVIDIA/NeMo/blob/main/docs/source/tts/data/ngc_models_aligner.csv
I looked at that table earlier and wasn't quite sure how to distinguish it--they're on the same model card so all the fields would remain the same. Do you have a suggestion for how we could make it clearer in these tables? |
right, I remembered this. I saw you added a new entry in Versions section in the model card. Then We are good to merge. Let's keep this as an open discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: 1-800-bad-code <shane.carroll@utsa.edu>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Signed-off-by: Jocelyn Huang jocelynh@nvidia.com
What does this PR do ?
Add option to load IPA-based checkpoints for FastPitch and the TTS Aligner.
Collection: TTS
Changelog
Usage