Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NGC links for Aligner and FastPitch #5235

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Conversation

redoctopus
Copy link
Collaborator

Signed-off-by: Jocelyn Huang jocelynh@nvidia.com

What does this PR do ?

Add option to load IPA-based checkpoints for FastPitch and the TTS Aligner.

Collection: TTS

Changelog

  • Added one entry each to the Aligner model and FastPitch model NGC model loading.
  • Did not add entries to the checkpoints table in the TTS documentation since they are new versions of existing model cards, and each entry in each checkpoint table is a single model card.

Usage

from nemo.collections.tts.models import AlignerModel, FastPitchModel

# IPA Aligner
aligner = AlignerModel.from_pretrained("tts_en_radtts_aligner_ipa")
# IPA FastPitch
fastpitch = FastPitchMode.from_pretrained("tts_en_fastpitch_ipa")

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Copy link
Collaborator

@XuesongYang XuesongYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you also add this IPA aligner into NeMo doc and distinguish wit Arpabet? https://github.com/NVIDIA/NeMo/blob/main/docs/source/tts/data/ngc_models_aligner.csv

@redoctopus
Copy link
Collaborator Author

Thanks. Could you also add this IPA aligner into NeMo doc and distinguish wit Arpabet? https://github.com/NVIDIA/NeMo/blob/main/docs/source/tts/data/ngc_models_aligner.csv

I looked at that table earlier and wasn't quite sure how to distinguish it--they're on the same model card so all the fields would remain the same. Do you have a suggestion for how we could make it clearer in these tables?

@XuesongYang
Copy link
Collaborator

I looked at that table earlier and wasn't quite sure how to distinguish it--they're on the same model card so all the fields would remain the same. Do you have a suggestion for how we could make it clearer in these tables?

right, I remembered this. I saw you added a new entry in Versions section in the model card. Then We are good to merge. Let's keep this as an open discussion.

Copy link
Collaborator

@XuesongYang XuesongYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@redoctopus redoctopus merged commit ea02fb2 into main Oct 25, 2022
@redoctopus redoctopus deleted the add_ipa_checkpoints branch October 25, 2022 01:17
1-800-BAD-CODE pushed a commit to 1-800-BAD-CODE/NeMo that referenced this pull request Nov 13, 2022
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: 1-800-bad-code <shane.carroll@utsa.edu>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 29, 2022
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>

Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants