-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL import functionality for Audio Lexical PNC Models #5834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Egert <degert@nvidia.com>
for more information, see https://pre-commit.ci
jubick1337
requested changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just minor changes
nemo/collections/nlp/models/token_classification/punctuation_capitalization_model.py
Outdated
Show resolved
Hide resolved
nemo/collections/nlp/models/token_classification/punctuation_capitalization_model.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Egert <degert@nvidia.com>
Signed-off-by: Daniel Egert <degert@nvidia.com>
jubick1337
approved these changes
Jan 23, 2023
Kipok
pushed a commit
to Kipok/NeMo
that referenced
this pull request
Jan 31, 2023
* Initial commit of changes for SSL functionality Signed-off-by: Daniel Egert <degert@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Deleted comment lines as per request Signed-off-by: Daniel Egert <degert@nvidia.com> Signed-off-by: Daniel Egert <degert@nvidia.com> Co-authored-by: Daniel Egert <degert@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
ericharper
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Initial commit of changes for SSL functionality Signed-off-by: Daniel Egert <degert@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Deleted comment lines as per request Signed-off-by: Daniel Egert <degert@nvidia.com> Signed-off-by: Daniel Egert <degert@nvidia.com> Co-authored-by: Daniel Egert <degert@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
ericharper
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Initial commit of changes for SSL functionality Signed-off-by: Daniel Egert <degert@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Deleted comment lines as per request Signed-off-by: Daniel Egert <degert@nvidia.com> Signed-off-by: Daniel Egert <degert@nvidia.com> Co-authored-by: Daniel Egert <degert@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
Kipok
pushed a commit
to Kipok/NeMo
that referenced
this pull request
Jan 31, 2023
* Initial commit of changes for SSL functionality Signed-off-by: Daniel Egert <degert@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Deleted comment lines as per request Signed-off-by: Daniel Egert <degert@nvidia.com> Signed-off-by: Daniel Egert <degert@nvidia.com> Co-authored-by: Daniel Egert <degert@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
titu1994
pushed a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* Initial commit of changes for SSL functionality Signed-off-by: Daniel Egert <degert@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Deleted comment lines as per request Signed-off-by: Daniel Egert <degert@nvidia.com> Signed-off-by: Daniel Egert <degert@nvidia.com> Co-authored-by: Daniel Egert <degert@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matvei Novikov <mattyson.so@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Egert degert@nvidia.com
What does this PR do ?
This PR allows the audio lexical PNC model to also import pretrained SSL models for the audio encoder, and allows importing any audio encoder which is on disk, and not just on NGC
Collection: [Note which collection this PR will affect]
NLP
Changelog
.restore_from
instead of just.from_pretrained
Usage
You can now specify
model.audio_encoder.pretrained_model
to be a .nemo file on disk rather than just the name of a model in NGC. This is set in the config yaml of the audio lexical model.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information