-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ClearML Logging #6014
Add ClearML Logging #6014
Conversation
Signed-off-by: Artem Zemliak <azemlyak@smart-consulting.ru>
Signed-off-by: Artem Zemliak <azemlyak@smart-consulting.ru>
Hi! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the PR ! While the PR does follow the general guidance on optional dependencies (thank you for that), it adds significant custom functions that do not particularly belong in exp manager.
A proposal would be to build a Pytorch Lighting Logger that handles the internals for you and then that object is imported and instantiated inside exp manager.
@SeanNaren please take a look
Thanks for explonaition! I first thought for implementing Pytorch Lighting Logger for ClearML. But I whanted to save I will try to build a Pytorch Lighting Logger for ClearML with same funcs. |
Thanks for this PR @ArtyomZemlyak! Agree with the above suggestion, if we can fit this into a I thought this could go directly into Lightning but they changed their policy: Lightning-AI/pytorch-lightning#14137 (comment) unfortunately. Not sure why, considering these are important third party libraries (I think HF Trainer even integrates directly). |
Signed-off-by: Артём Земляк <azemlyak@smart-consulting.ru>
Signed-off-by: Артём Земляк <azemlyak@smart-consulting.ru>
@titu1994 Tried implement ClearMLLogger for |
Looks fantastic! Just a small comment :) |
Signed-off-by: Артём Земляк <azemlyak@smart-consulting.ru>
Signed-off-by: Артём Земляк <azemlyak@smart-consulting.ru>
Signed-off-by: Артём Земляк <azemlyak@smart-consulting.ru>
Signed-off-by: Артём Земляк <azemlyak@smart-consulting.ru>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice addition!
* Add ClearML Logging Signed-off-by: Artem Zemliak <azemlyak@smart-consulting.ru> Co-authored-by: Sean Naren <snarenthiran@nvidia.com>
* Add ClearML Logging Signed-off-by: Artem Zemliak <azemlyak@smart-consulting.ru> Co-authored-by: Sean Naren <snarenthiran@nvidia.com> Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
What does this PR do ?
Adding ClearML integration for logging of training process:
Collection: [Note which collection this PR will affect]
utils
Changelog
loggers
module intonemo.utils
clearml_logger.py
intonemo.utils.loggers
ClearMLParams
andClearMLLogger
classes intoclearml_logger.py
dllogger.py
tonemo.utils.loggers
Usage
In model config.yml file:
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information