Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix notebook error #6840

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix notebook error #6840

merged 1 commit into from
Jun 8, 2023

Conversation

yidong72
Copy link
Collaborator

@yidong72 yidong72 commented Jun 8, 2023

fix megatron_ckpt_to_nemo.py: error: unrecognized arguments: --local-rank=0 error

Signed-off-by: Yi Dong <yidong@nvidia.com>
@yidong72 yidong72 requested a review from ericharper June 8, 2023 18:57
@github-actions github-actions bot added the NLP label Jun 8, 2023
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit dc52b94 into r1.19.0 Jun 8, 2023
@ericharper ericharper deleted the fix_notebook branch June 8, 2023 19:48
github-actions bot pushed a commit that referenced this pull request Jun 8, 2023
Signed-off-by: Yi Dong <yidong@nvidia.com>
ericharper pushed a commit that referenced this pull request Jun 29, 2023
Signed-off-by: Yi Dong <yidong@nvidia.com>
ericharper added a commit that referenced this pull request Jun 29, 2023
* Cut branch r1.19.0

Signed-off-by: smajumdar <titu1994@gmail.com>

* Tutorial fixes (#6717)

Signed-off-by: smajumdar <titu1994@gmail.com>

* fix notebook error (#6840)

Signed-off-by: Yi Dong <yidong@nvidia.com>

* fix (#6842)

Signed-off-by: Yi Dong <yidong@nvidia.com>

* update branch

Signed-off-by: ericharper <complex451@gmail.com>

* update package info

Signed-off-by: ericharper <complex451@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Yi Dong <yidong@nvidia.com>
Signed-off-by: ericharper <complex451@gmail.com>
Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
Co-authored-by: Yi Dong <43824965+yidong72@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants