Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a typo #7457

Closed
wants to merge 0 commits into from
Closed

fix a typo #7457

wants to merge 0 commits into from

Conversation

BestJuly
Copy link
Contributor

What does this PR do ?

Fix a typo.

Collection: NLP

Changelog

Fix a typo in the comment part in nemo/collections/nlp/data/language_modeling/megatron/helpers.cpp.

Usage

Do not affect any usage

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Sep 19, 2023
@jubick1337
Copy link
Collaborator

Hello @BestJuly
Could you please fix the DCO issue, it is described here?

@BestJuly
Copy link
Contributor Author

Hi @jubick1337. It seems that I have done fool things and it is automatically closed. Please ignore this PR and the new one is #7496, which should be OK. Sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants