Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Aware Streaming tutorial notebook [old PR, closed] #8036

Closed

Conversation

erastorgueva-nv
Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv commented Dec 15, 2023

Update: this PR is closed, replaced with #8296

cc @vsl9, @VahidooX

What does this PR do ?

Adding the notebook that allows us to do real-time streaming using a cache-aware fastconformer model (supports single-lookahead and multi-lookahead models).

Collection: tutorials/asr

Changelog

  • Add cache-aware streaming notebook in tutorials/asr
  • Add call to self.setup_streaming_params inside set_default_att_context_size method of ConformerEncoder.

Usage

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the ASR label Dec 15, 2023
Copy link
Contributor

github-actions bot commented Jan 3, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jan 3, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

VahidooX
VahidooX previously approved these changes Jan 26, 2024
Copy link
Collaborator

@VahidooX VahidooX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left a minor comment.

docs/source/starthere/tutorials.rst Outdated Show resolved Hide resolved
VahidooX
VahidooX previously approved these changes Jan 31, 2024
@erastorgueva-nv erastorgueva-nv changed the base branch from main to r1.23.0 January 31, 2024 00:45
@erastorgueva-nv erastorgueva-nv dismissed VahidooX’s stale review January 31, 2024 00:45

The base branch was changed.

@erastorgueva-nv erastorgueva-nv changed the base branch from r1.23.0 to main January 31, 2024 00:46
@erastorgueva-nv erastorgueva-nv changed the base branch from main to r1.23.0 January 31, 2024 00:47
@github-actions github-actions bot added core Changes to NeMo Core TTS NLP CI common labels Jan 31, 2024
@erastorgueva-nv erastorgueva-nv changed the base branch from r1.23.0 to main January 31, 2024 01:08
@erastorgueva-nv erastorgueva-nv changed the title Add tutorial notebook for cache-aware streaming Cache Aware Streaming tutorial notebook [old PR, closed] Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants