Add Canary support for decoding with return_hypotheses=True #8338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
|
jenkins |
|
Uh I'm adding support for this in my ASR transcribe refactor |
|
Actually let's keep this PR open, we'll get it rebased on the transcribe pr |
Signed-off-by: stevehuang52 <heh@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
|
jenkins |
Signed-off-by: stevehuang52 <heh@nvidia.com>
|
jenkins |
biscayan
pushed a commit
to biscayan/NeMo
that referenced
this pull request
Feb 15, 2024
) * change default decoding to beam=1 and length up to decoder max len Signed-off-by: stevehuang52 <heh@nvidia.com> * add Canary support for return_hypotheses=True Signed-off-by: stevehuang52 <heh@nvidia.com> * change len_pen default to 0 Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for nbest hypotheses Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for return best hypo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Signed-off-by: biscayan <skgudwn34@gmail.com>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
) * change default decoding to beam=1 and length up to decoder max len Signed-off-by: stevehuang52 <heh@nvidia.com> * add Canary support for return_hypotheses=True Signed-off-by: stevehuang52 <heh@nvidia.com> * change len_pen default to 0 Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for nbest hypotheses Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for return best hypo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Signed-off-by: Sasha Meister <ameister@nvidia.com>
zpx01
pushed a commit
to zpx01/NeMo
that referenced
this pull request
Mar 8, 2024
) * change default decoding to beam=1 and length up to decoder max len Signed-off-by: stevehuang52 <heh@nvidia.com> * add Canary support for return_hypotheses=True Signed-off-by: stevehuang52 <heh@nvidia.com> * change len_pen default to 0 Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for nbest hypotheses Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for return best hypo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Signed-off-by: Zeeshan Patel <zeeshanp@berkeley.edu>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
* change default decoding to beam=1 and length up to decoder max len Signed-off-by: stevehuang52 <heh@nvidia.com> * add Canary support for return_hypotheses=True Signed-off-by: stevehuang52 <heh@nvidia.com> * change len_pen default to 0 Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for nbest hypotheses Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for return best hypo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com> Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
) * change default decoding to beam=1 and length up to decoder max len Signed-off-by: stevehuang52 <heh@nvidia.com> * add Canary support for return_hypotheses=True Signed-off-by: stevehuang52 <heh@nvidia.com> * change len_pen default to 0 Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for nbest hypotheses Signed-off-by: stevehuang52 <heh@nvidia.com> * fix for return best hypo Signed-off-by: stevehuang52 <heh@nvidia.com> --------- Signed-off-by: stevehuang52 <heh@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Collection: [asr]