-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "index 0 is out of bounds for dimension 1 with size 0" #8739
Conversation
Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
Optimized the number of segments used based on the length of the audio Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Sasha.
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
Signed-off-by: ssh-meister <ssh-meister@users.noreply.github.com>
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
This PR was closed because it has been inactive for 7 days since being marked as stale. |
In the code, the variable
audio
containing the original audio recording gets overwritten during the operationaudio[start: start + duration]
. Consequently, on subsequent iterations of the loop, a segment of a new length cannot be processed correctly because the timestamps of the segment exceed the boundaries of the overwrittenaudio
.This PR addresses this issue by proposing a fix to ensure that the overwritten
audio
variable does not cause incorrect processing of subsequent segments.