Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "index 0 is out of bounds for dimension 1 with size 0" #8739

Closed
wants to merge 12 commits into from

Conversation

ssh-meister
Copy link
Collaborator

In the code, the variable audio containing the original audio recording gets overwritten during the operation audio[start: start + duration]. Consequently, on subsequent iterations of the loop, a segment of a new length cannot be processed correctly because the timestamps of the segment exceed the boundaries of the overwritten audio.

This PR addresses this issue by proposing a fix to ensure that the overwritten audio variable does not cause incorrect processing of subsequent segments.

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
@ssh-meister ssh-meister requested a review from karpnv March 25, 2024 11:11
@github-actions github-actions bot added the ASR label Mar 25, 2024
ssh-meister and others added 4 commits April 5, 2024 09:55
Optimized the number of segments used based on the length of the audio

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
karpnv
karpnv previously approved these changes Apr 16, 2024
Copy link
Collaborator

@karpnv karpnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Signed-off-by: Sasha Meister <117230141+ssh-meister@users.noreply.github.com>
karpnv
karpnv previously approved these changes Apr 16, 2024
Copy link
Collaborator

@karpnv karpnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vsl9
vsl9 previously approved these changes Apr 29, 2024
Copy link
Collaborator

@vsl9 vsl9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sasha.

Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 14, 2024
ssh-meister and others added 2 commits May 15, 2024 17:32
Signed-off-by: ssh-meister <ssh-meister@users.noreply.github.com>
@artbataev artbataev dismissed stale reviews from vsl9 and karpnv via 5e8ab25 May 15, 2024 15:33
@ssh-meister ssh-meister requested review from karpnv and vsl9 May 29, 2024 13:13
@github-actions github-actions bot removed the stale label Jul 26, 2024
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 10, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants