Akoumparouli/fix sd train 2 #8883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
|
jenkins |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumparouli/fix_sd_train_2
branch
from
94ef985
to
deb52ed
Compare
|
jenkins |
…precision is set Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
for more information, see https://pre-commit.ci
|
jenkins |
|
Set unet_precision when user not set it. |
|
jenkins |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
|
jenkins |
ericharper
requested review from
ShriyaPalsamudram
and removed request for
dimapihtar
|
jenkins |
|
jenkins |
ShriyaPalsamudram
previously approved these changes
Apr 12, 2024
|
jenkins |
1 similar comment
|
jenkins |
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
|
jenkins |
|
jenkins |
|
jenkins |
ShriyaPalsamudram
approved these changes
Apr 17, 2024
xingyaoww
pushed a commit
to xingyaoww/NeMo
that referenced
this pull request
Apr 23, 2024
* Use fp16 in unet if cfg.precision is 16bit Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * remove temp fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * guard unet_precision value setting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * formatting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * throw a warning if unet_config.unet_precision is not set but trainer.precision is set Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use model.optim.name=megatron_fused_adam in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * use bf16 in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
alxzhang-amazon
pushed a commit
to alxzhang-amazon/NeMo
that referenced
this pull request
Apr 26, 2024
* Use fp16 in unet if cfg.precision is 16bit Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * remove temp fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * guard unet_precision value setting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * formatting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * throw a warning if unet_config.unet_precision is not set but trainer.precision is set Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use model.optim.name=megatron_fused_adam in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * use bf16 in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
suiyoubi
pushed a commit
that referenced
this pull request
May 2, 2024
* Use fp16 in unet if cfg.precision is 16bit Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * remove temp fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * guard unet_precision value setting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * formatting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * throw a warning if unet_config.unet_precision is not set but trainer.precision is set Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use model.optim.name=megatron_fused_adam in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * use bf16 in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Ao Tang <aot@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Use fp16 in unet if cfg.precision is 16bit Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * remove temp fix Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * guard unet_precision value setting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * formatting Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * throw a warning if unet_config.unet_precision is not set but trainer.precision is set Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * use model.optim.name=megatron_fused_adam in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * use bf16 in sd_train Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
pass fp16 precision to UNetModel constructor if user specifies fp16 precision via CLI.
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information