Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transpose call to match TE API change #8918

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

ShriyaPalsamudram
Copy link
Collaborator

@ShriyaPalsamudram ShriyaPalsamudram commented Apr 14, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the core Changes to NeMo Core label Apr 14, 2024
@ShriyaPalsamudram
Copy link
Collaborator Author

jenkins

@ShriyaPalsamudram ShriyaPalsamudram marked this pull request as draft April 14, 2024 00:32
@ShriyaPalsamudram ShriyaPalsamudram marked this pull request as ready for review April 15, 2024 14:50
Copy link
Member

@ksivaman ksivaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksivaman
Copy link
Member

@ShriyaPalsamudram Could you sign off your commit using git commit --amend --signoff?

Signed-off-by: Shriya Palsamudram <spalsamudram@nvidia.com>
@ShriyaPalsamudram
Copy link
Collaborator Author

jenkins

@timmoon10
Copy link
Collaborator

Alternatively, #8751 fixes this bug by removing the transpose caching and relying on the caching logic in te.make_graphed_callables with fp8_weight_caching=True.

@ShriyaPalsamudram
Copy link
Collaborator Author

jenkins

@pablo-garay pablo-garay merged commit fc25bcc into r2.0.0.rc0.beta Apr 16, 2024
10 checks passed
@pablo-garay pablo-garay deleted the shriya/dist_adam_transpose branch April 16, 2024 00:06
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
Signed-off-by: Shriya Palsamudram <spalsamudram@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants