Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter of embedding_read_fusion for MCoreGPTModel #8923

Closed

Conversation

hannahli-nv
Copy link

What does this PR do ?

This PR adds the support for embedding_read_fusion parameter in MCoreGPTModel. This new parameter will be added into Megatron-LM.

Collection: [Note which collection this PR will affect]

Changelog

Add the embedding_read_fusion parameter, which is got from self.cfg.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Apr 15, 2024
@hannahli-nv hannahli-nv changed the base branch from main to r2.0.0.rc0.beta April 15, 2024 16:21
@github-actions github-actions bot added the CI label Apr 17, 2024
Signed-off-by: Hannah Li <hanli@login-eos02.eos.clusters.nvidia.com>
@hannahli-nv hannahli-nv reopened this Apr 17, 2024
@github-actions github-actions bot removed the CI label Apr 17, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 2, 2024
Copy link
Contributor

github-actions bot commented May 9, 2024

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant