Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixtral_nemo_to_hf conversion #9023

Closed

Conversation

tdene
Copy link
Contributor

@tdene tdene commented Apr 23, 2024

What does this PR do ?

Fix convert_mixtral_nemo_to_hf.py

Collection: scripts/checkpoint_converters

Changelog

  • Fix two typos
  • Allow for custom tokenizer to be passed in

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Who can review?

@cuichenx

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@janekl
Copy link
Collaborator

janekl commented Apr 24, 2024

Is it fine & really required to introduce extra param --input_tokenizer?

If yes, should we update relevant docs? https://github.com/NVIDIA/NeMo/blob/main/docs/source/ckpt_converters/dev_guide.rst

CC @yaoyu-33 - please have a look, maybe you will have some comments

@tdene
Copy link
Contributor Author

tdene commented Apr 24, 2024

Is it fine & really required to introduce extra param --input_tokenizer?

I'm modeling this off #8000. In both cases, the problem is that the converter tries to use the default HuggingFace tokenizer, while the custom model that's being converted may well be using a different tokenizer.

Perhaps the correct solution in both cases is to unpack the tokenizer out of the .nemo file during the conversion script, instead of adding a --input_tokenizer argument.

Copy link
Contributor

github-actions bot commented May 9, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 9, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants