Cleanup deprecated files and temporary changes #9088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
yaoyu-33
previously approved these changes
May 2, 2024
Signed-off-by: Chen Cui <chcui@nvidia.com>
yaoyu-33
previously approved these changes
May 2, 2024
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com>
|
Pipeline passed: https://github.com/NVIDIA/NeMo/actions/runs/9018587937 |
Signed-off-by: Chen Cui <chcui@nvidia.com>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jun 5, 2024
* remove deprecated files Signed-off-by: Chen Cui <chcui@nvidia.com> * remove temporary changes Signed-off-by: Chen Cui <chcui@nvidia.com> * remove incorrect deprecation notice Signed-off-by: Chen Cui <chcui@nvidia.com> * revert rope fusion defaults Signed-off-by: Chen Cui <chcui@nvidia.com> * update tests Signed-off-by: Chen Cui <chcui@nvidia.com> * update tests Signed-off-by: Chen Cui <chcui@nvidia.com> * fix failing test Signed-off-by: Chen Cui <chcui@nvidia.com> * add assert Signed-off-by: Chen Cui <chcui@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove jenkinsfile to resolve merge conflict Signed-off-by: Chen Cui <chcui@nvidia.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* remove deprecated files Signed-off-by: Chen Cui <chcui@nvidia.com> * remove temporary changes Signed-off-by: Chen Cui <chcui@nvidia.com> * remove incorrect deprecation notice Signed-off-by: Chen Cui <chcui@nvidia.com> * revert rope fusion defaults Signed-off-by: Chen Cui <chcui@nvidia.com> * update tests Signed-off-by: Chen Cui <chcui@nvidia.com> * update tests Signed-off-by: Chen Cui <chcui@nvidia.com> * fix failing test Signed-off-by: Chen Cui <chcui@nvidia.com> * add assert Signed-off-by: Chen Cui <chcui@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove jenkinsfile to resolve merge conflict Signed-off-by: Chen Cui <chcui@nvidia.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Eric Harper <complex451@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
There's no need to comment
jenkinson the PR to trigger Jenkins CI.The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information