Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apex import Guard for MM collection #9099

Closed
wants to merge 4 commits into from
Closed

Conversation

suiyoubi
Copy link
Collaborator

@suiyoubi suiyoubi commented May 2, 2024

No description provided.

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please capture the error and include in the ImportError so users will know exactly what's not being imported properly.

@suiyoubi
Copy link
Collaborator Author

suiyoubi commented May 2, 2024

Please capture the error and include in the ImportError so users will know exactly what's not being imported properly.

ImportError is raised at the model level not layer level. Most of the cases here are using Apex's groupnorm, I added the ImportError when instantiate the model, not for each layer we invoke groupnorm.

@ericharper do you think this is sufficient ?

Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 17, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants