-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAG Pipeline #9143
Merged
Merged
RAG Pipeline #9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 9, 2024 17:06
43fe4af
to
b48b7e5
Compare
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 9, 2024 17:23
7c7f3c0
to
ee99815
Compare
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 9, 2024 18:00
66f8d02
to
356c79e
Compare
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 17, 2024 21:18
6e8ba23
to
d644201
Compare
…nd LLMs in future
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 20, 2024 20:24
d55dcef
to
8633e46
Compare
JRD971000
reviewed
May 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! Adding some comments:
- Please remove the redundant imports
- Change print to nemo logging
JRD971000
reviewed
May 21, 2024
JRD971000
reviewed
May 21, 2024
JRD971000
reviewed
May 21, 2024
JRD971000
reviewed
May 21, 2024
JRD971000
reviewed
May 21, 2024
JRD971000
reviewed
May 21, 2024
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 21, 2024 18:48
ea2adee
to
0c1ae82
Compare
huvunvidia
force-pushed
the
huvu/rag_pipeline
branch
from
May 22, 2024 04:43
fe9bdf6
to
c390967
Compare
JRD971000
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jun 5, 2024
* first commit * working pipeline rag_indexing; rag_eval with rag.yaml * udpate RAG documentation * add image to documents * cleaning docs * before merge from main * refactor code to make it easier to support more customized embedder and LLMs in future * addressing Ali's comments * addressing Ali's comments * addressing Ali's comments * fix Code scanning results / CodeQL --------- Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
janekl
pushed a commit
that referenced
this pull request
Jun 12, 2024
* first commit * working pipeline rag_indexing; rag_eval with rag.yaml * udpate RAG documentation * add image to documents * cleaning docs * before merge from main * refactor code to make it easier to support more customized embedder and LLMs in future * addressing Ali's comments * addressing Ali's comments * addressing Ali's comments * fix Code scanning results / CodeQL --------- Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* first commit * working pipeline rag_indexing; rag_eval with rag.yaml * udpate RAG documentation * add image to documents * cleaning docs * before merge from main * refactor code to make it easier to support more customized embedder and LLMs in future * addressing Ali's comments * addressing Ali's comments * addressing Ali's comments * fix Code scanning results / CodeQL --------- Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use this
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information