Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAG Pipeline #9143

Merged
merged 12 commits into from
May 22, 2024
Merged

RAG Pipeline #9143

merged 12 commits into from
May 22, 2024

Conversation

huvunvidia
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label May 8, 2024
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_llm.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_llm.py Fixed Show fixed Hide fixed
nemo/collections/nlp/models/rag/custom_llm.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_eval.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
Copy link
Collaborator

@JRD971000 JRD971000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! Adding some comments:

  • Please remove the redundant imports
  • Change print to nemo logging

examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
examples/nlp/rag/rag.md Outdated Show resolved Hide resolved
examples/nlp/rag/rag_generating.py Fixed Show fixed Hide fixed
examples/nlp/rag/rag_indexing.py Fixed Show fixed Hide fixed
Copy link
Collaborator

@JRD971000 JRD971000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JRD971000 JRD971000 merged commit fe7e2e5 into main May 22, 2024
133 checks passed
@JRD971000 JRD971000 deleted the huvu/rag_pipeline branch May 22, 2024 15:41
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* first commit

* working pipeline rag_indexing; rag_eval with rag.yaml

* udpate RAG documentation

* add image to documents

* cleaning docs

* before merge from main

* refactor code to make it easier to support more customized embedder and LLMs in future

* addressing Ali's comments

* addressing Ali's comments

* addressing Ali's comments

* fix Code scanning results / CodeQL

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
janekl pushed a commit that referenced this pull request Jun 12, 2024
* first commit

* working pipeline rag_indexing; rag_eval with rag.yaml

* udpate RAG documentation

* add image to documents

* cleaning docs

* before merge from main

* refactor code to make it easier to support more customized embedder and LLMs in future

* addressing Ali's comments

* addressing Ali's comments

* addressing Ali's comments

* fix Code scanning results / CodeQL

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* first commit

* working pipeline rag_indexing; rag_eval with rag.yaml

* udpate RAG documentation

* add image to documents

* cleaning docs

* before merge from main

* refactor code to make it easier to support more customized embedder and LLMs in future

* addressing Ali's comments

* addressing Ali's comments

* addressing Ali's comments

* fix Code scanning results / CodeQL

---------

Co-authored-by: Huy Vu2 <huvu@login-eos01.eos.clusters.nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants