Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guards to SD imports #9158

Merged
merged 2 commits into from
May 14, 2024
Merged

Add guards to SD imports #9158

merged 2 commits into from
May 14, 2024

Conversation

yaoyu-33
Copy link
Collaborator

@yaoyu-33 yaoyu-33 commented May 9, 2024

What does this PR do ?

Add guards to SD imports. So that pip install'ed NeMo won't fail the imports.

Collection: [multimodal]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

OPT_GROUP_NORM = True
except Exception:
print('Fused optimized group norm has not been installed.')

Check notice

Code scanning / CodeQL

Use of a print statement at module level Note

Print statement may execute during import.
from transformer_engine.pytorch.module import LayerNormLinear, LayerNormMLP
OPT_GROUP_NORM = True
except Exception:
print('Fused optimized group norm has not been installed.')

Check notice

Code scanning / CodeQL

Use of a print statement at module level Note

Print statement may execute during import.

OPT_GROUP_NORM = True
except Exception:
print('Fused optimized group norm has not been installed.')

Check notice

Code scanning / CodeQL

Use of a print statement at module level Note

Print statement may execute during import.

OPT_GROUP_NORM = True
except Exception:
print('Fused optimized group norm has not been installed.')

Check notice

Code scanning / CodeQL

Use of a print statement at module level Note

Print statement may execute during import.

OPT_GROUP_NORM = True
except Exception:
print('Fused optimized group norm has not been installed.')

Check notice

Code scanning / CodeQL

Use of a print statement at module level Note

Print statement may execute during import.
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@yaoyu-33 yaoyu-33 merged commit 5df8e11 into main May 14, 2024
130 checks passed
@yaoyu-33 yaoyu-33 deleted the yuya/fix_sd_import branch May 14, 2024 22:16
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* Add guards to SD imports

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Add guards to SD imports

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants