Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support for push_to_hf_hub() #9159

Merged
merged 2 commits into from
May 9, 2024
Merged

Update support for push_to_hf_hub() #9159

merged 2 commits into from
May 9, 2024

Conversation

titu1994
Copy link
Collaborator

@titu1994 titu1994 commented May 9, 2024

What does this PR do ?

Add documentation for using push_to_hf_hub() at a ModelPT level

Collection: [Core]

Changelog

  • Adds sections showing automated upload to HF Hub

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
@ericharper ericharper merged commit 0cb7848 into main May 9, 2024
19 of 132 checks passed
@ericharper ericharper deleted the tutorial_uploadtohf branch May 9, 2024 22:43
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* Update support for push_to_hf_hub()

Signed-off-by: smajumdar <titu1994@gmail.com>

* Revert nlp comment out

Signed-off-by: smajumdar <titu1994@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Update support for push_to_hf_hub()

Signed-off-by: smajumdar <titu1994@gmail.com>

* Revert nlp comment out

Signed-off-by: smajumdar <titu1994@gmail.com>

---------

Signed-off-by: smajumdar <titu1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants