Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MoE EP rank when TP is set at the same time #9161

Merged
merged 2 commits into from
May 13, 2024

Conversation

gdengk
Copy link
Contributor

@gdengk gdengk commented May 10, 2024

What does this PR do ?

EP rank is not right when TP is set at the same time, which causes accuracy mismatch and functionality failure.
We saw alltoall-v illegal memory access when using TP2EP2DP2. Fixing this has resolve the issue.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label May 10, 2024
@akoumpa akoumpa self-requested a review May 10, 2024 04:36
Copy link
Member

@akoumpa akoumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Signed-off-by: Gao Deng <gdeng@nvidia.com>
@gdengk gdengk force-pushed the gaod/moe/fix_nemo_ep_rank branch from 85599b9 to fbac3e0 Compare May 10, 2024 20:35
@akoumpa akoumpa added Run CICD and removed Run CICD labels May 13, 2024
@pablo-garay
Copy link
Collaborator

CI is having issues with one flaky test (Speech_Checkpoints_tests timing out), but other than that it passed

@pablo-garay pablo-garay merged commit 467d94b into NVIDIA:main May 13, 2024
127 of 128 checks passed
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
Signed-off-by: Gao Deng <gdeng@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Signed-off-by: Gao Deng <gdeng@nvidia.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
@gdengk gdengk deleted the gaod/moe/fix_nemo_ep_rank branch October 2, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants