Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Refactor NeMo-ci by introducing a reusable workflow template #9177

Closed
wants to merge 6 commits into from

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented May 13, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the CI label May 13, 2024
@ko3n1g ko3n1g changed the title Ko3n1g/refactor/nemo cicd the second ci: Refactor NeMo-ci by introducing a reusable workflow template May 13, 2024
@ko3n1g ko3n1g requested a review from pablo-garay May 13, 2024 09:00
@ko3n1g
Copy link
Collaborator Author

ko3n1g commented May 13, 2024

Hey @pablo-garay, this is a poc for the discussed refactoring approach. If you like it, I will continue refactoring the remaining test cases. Please feel free to leave some comments!

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g marked this pull request as ready for review May 13, 2024 17:22
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g changed the base branch from main to ko3n1g/ci/add-dockerfile May 15, 2024 19:36
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/refactor/nemo-cicd-the-second branch from fa4aa87 to 65d9839 Compare May 15, 2024 19:37
@ko3n1g ko3n1g marked this pull request as draft May 16, 2024 09:07
Base automatically changed from ko3n1g/ci/add-dockerfile to main May 16, 2024 18:45
Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label May 31, 2024
@ko3n1g ko3n1g closed this Jun 3, 2024
@ko3n1g ko3n1g deleted the ko3n1g/refactor/nemo-cicd-the-second branch June 3, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant