Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward #9246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titu1994
previously approved these changes
May 18, 2024
…r::forward GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do. Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com>
Signed-off-by: titu1994 <titu1994@users.noreply.github.com>
Signed-off-by: Daniel Galvez <dgalvez@nvidia.com>
galv
force-pushed
the
dgalvez/fix-decoder-lengths-none
branch
from
2066dc3
to
32a7881
Compare
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
…r::forward (#9246) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do. Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Log warning only once for sanity. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com>
titu1994
added a commit
that referenced
this pull request
May 22, 2024
…r::forward (#9278) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward (#9246) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do. Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Log warning only once for sanity. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> Co-authored-by: Daniel Galvez <galv@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jun 5, 2024
…r::forward (NVIDIA#9278) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward (NVIDIA#9246) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do. Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Log warning only once for sanity. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> Co-authored-by: Daniel Galvez <galv@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: nithinraok <nithinraok@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
janekl
pushed a commit
that referenced
this pull request
Jun 12, 2024
…r::forward (#9278) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward (#9246) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do. Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Log warning only once for sanity. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> Co-authored-by: Daniel Galvez <galv@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: nithinraok <nithinraok@users.noreply.github.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…r::forward (NVIDIA#9278) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward (NVIDIA#9246) * Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do. Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> * Apply isort and black reformatting Signed-off-by: titu1994 <titu1994@users.noreply.github.com> * Log warning only once for sanity. Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> * Apply isort and black reformatting Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> --------- Signed-off-by: Daniel Galvez <dgalvez@nvidia.com> Signed-off-by: titu1994 <titu1994@users.noreply.github.com> Signed-off-by: nithinraok <nithinraok@users.noreply.github.com> Co-authored-by: Daniel Galvez <galv@users.noreply.github.com> Co-authored-by: titu1994 <titu1994@users.noreply.github.com> Co-authored-by: Somshubra Majumdar <titu1994@gmail.com> Co-authored-by: Nithin Rao <nithinrao.koluguri@gmail.com> Co-authored-by: nithinraok <nithinraok@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GreedyCTCInfer::forward already allowed for this, so they did not implement the exact same interface. Now, they do.
Also warn about not passing in the decoder_lengths argument. It is likely an error on the user's part not to pass it in explicitly.
What does this PR do ?
Accept None as an argument to decoder_lengths in GreedyBatchedCTCInfer::forward
Collection: ASR
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.